fix HTML filter issue when the text contains malformed HTML tags #27
Conversation
| @@ -258,6 +258,10 @@ function ($match) { | |||
| */ | |||
| private function isIgnoredTag(?string $name): bool | |||
| { | |||
| if ($name === null) { | |||
| return false; | |||
There was a problem hiding this comment.
I think the tag should be ignored if its malformed. So this should return true.
Or else you will get a array access on null in
php-speller/src/Source/Filter/HtmlFilter.php
Line 123 in 629e86d
There was a problem hiding this comment.
Thanks @icanhazstring .
Actually if the tag is ignored, the result of the filter becomes foo/ because the state is not restored and the text after the character > is replaced by spaces. Do you have any idea to solve it?
There was a problem hiding this comment.
The base problem here I think is: The script "thinks" it is parsing a closing tag with > but it shouldn't. Because it never started one using <.
Maybe there is a total underlying problem here with the parsing method.
So I would go with your initial solution as it is the more correct one.
So your case with $tagName !== null should be in here.
Maybe we can think of some other solution someday :D
There was a problem hiding this comment.
Thanks a lot for your help
There was a problem hiding this comment.
Thanks for fixing :)
| { | ||
| $filter = new HtmlFilter(); | ||
| $html = "foo/>bar<br><br/>"; | ||
| $text = "foo/ bar "; |
There was a problem hiding this comment.
Since the tag will be ignored the outcome should be foo/>bar
Fixes issue #26